Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add narrow no-break space support #9604

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

quentin-bettoum
Copy link
Contributor

@quentin-bettoum quentin-bettoum commented Feb 11, 2024

The goal of this PR is to support the rendering of narrow no-break spaces as asked in #6640.

Note that I'm not proficient in Rust, but since it looked simple, I gave it a try by looking at what have been done for regular nbsp.

The tests passes and the feature works using cargo run.

I don't know what's better between having a dedicated editor.whitespace.render option for nnbsp or including it in the existing nbsp parameter.

Currently, the new config parameters would look like this:

[editor.whitespace.render]
space = "all"
nbsp = "all"
nnbsp = "all"
tab = "all"
newline = "none"

[editor.whitespace.characters]
space = "·"
nbsp = ""
nnbsp = ""
tab = ""
newline = ""
tabpad = "·"

@the-mikedavis the-mikedavis added the S-waiting-on-review Status: Awaiting review from a maintainer. label Feb 11, 2024
@the-mikedavis the-mikedavis linked an issue Feb 11, 2024 that may be closed by this pull request
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Feb 17, 2024
@archseer archseer merged commit 614a744 into helix-editor:master Mar 25, 2024
6 checks passed
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@Iorvethe Iorvethe mentioned this pull request Apr 12, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add narrow no-break space to editor.whitespace
4 participants