-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add narrow no-break space support #9604
Merged
archseer
merged 3 commits into
helix-editor:master
from
quentin-bettoum:add-nnbsp-support
Mar 25, 2024
Merged
Add narrow no-break space support #9604
archseer
merged 3 commits into
helix-editor:master
from
quentin-bettoum:add-nnbsp-support
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
the
S-waiting-on-review
Status: Awaiting review from a maintainer.
label
Feb 11, 2024
the-mikedavis
approved these changes
Feb 11, 2024
archseer
approved these changes
Mar 25, 2024
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Mar 26, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
Merged
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-helix-term
Area: Helix term improvements
S-waiting-on-review
Status: Awaiting review from a maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to support the rendering of narrow no-break spaces as asked in #6640.
Note that I'm not proficient in Rust, but since it looked simple, I gave it a try by looking at what have been done for regular
nbsp
.The tests passes and the feature works using
cargo run
.I don't know what's better between having a dedicated
editor.whitespace.render
option fornnbsp
or including it in the existingnbsp
parameter.Currently, the new config parameters would look like this: